Skip to content

[FEAT]: implement builders and enums for subscription queries #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Sep 9, 2025
Merged

[FEAT]: implement builders and enums for subscription queries #74

merged 29 commits into from
Sep 9, 2025

Conversation

Doominika
Copy link
Contributor

@Doominika Doominika commented Aug 4, 2025 •
edited
Loading

Description

CHANGES

New classes

  • StoreEventType
  • ThreadEventType
  • InboxEventType
  • KvdbEventType
  • EventSelectorType
  • StoreEventSelectorType
  • ThreadEventSelectorType
  • InboxEventSelectorType
  • KvdbEventSelectorType
  • CustomEventSelectorType

@Doominika Doominika changed the base branch from main to feat/implement-2.6 August 4, 2025 11:21
@Doominika Doominika requested a review from djenczewski August 4, 2025 11:21
djenczewski
djenczewski requested changes Aug 7, 2025
View reviewed changes
@Doominika Doominika requested a review from djenczewski August 8, 2025 10:30
@Doominika
feat(privmx-endpoint): Implement new event subscription methods (#73)
0e896a5 
* refactor: delete old subscription methods from EventApi

* refactor: delete old subscription methods from InboxApi

* refactor: delete old subscription methods from KvdbApi

* refactor: delete old subscription methods from StoreApi

* refactor: delete old subscription methods from ThreadApi

* feat: add new subscription methods for EventApi

* feat: add new subscription methods for InboxApi

* feat: add new subscription methods for KvdbApi

* feat: add new subscription methods for StoreApi

* feat: add new subscription methods for StoreApi

* feat: declare thrown exceptions in methods

* chore: add exception descriptions to docs and fix typos

* feat: change native buildSubscriptionQuery method parameter types in ThreadApi

* feat: change native buildSubscriptionQuery method parameter types in StoreApi

* feat: change native buildSubscriptionQuery method parameter types in InboxApi

* feat: change native buildSubscriptionQuery method parameter types in KvdbApi

* fix: use pointer access for JniContextUtils methods

* feat: change native buildSubscriptionQuery method parameter types in EventApi

* chore: rename custom event selector type

* chore: change descriptions in null checks

* chore: change descriptions in null checks

* chore: cast long value to enum instead of using special function

* fix: use correct ctx method

* chore: remove syncFile method

* chore: clean up code
djenczewski
djenczewski requested changes Aug 19, 2025
View reviewed changes
Copy link
Member

@djenczewski djenczewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add documentation for all enums (description, group and catergory)

@Doominika Doominika requested a review from djenczewski August 28, 2025 10:20
djenczewski
djenczewski requested changes Sep 3, 2025
View reviewed changes
Copy link
Member

@djenczewski djenczewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modify descriptions in EventTypes and EventSelectors enums according to notes in InboxEventType and SelectorType

Doominika and others added 2 commits September 5, 2025 15:19
@Doominika
feat(privmx-endpoint): Add new event types for containers (#87)
61c2522 
* feat: add new enum value to containers event types

* feat: delete entryId value from kvdb event selector type
@djenczewski
docs(privmx-endpoint): add category and group tags to EventType and E…
4e4bdcd 
…ventSelectorType interfaces
filipg43
filipg43 reviewed Sep 9, 2025
View reviewed changes
...m/simplito/java/privmx_endpoint/model/events/eventSelectorTypes/CustomEventSelectorType.java Outdated
package com.simplito.java.privmx_endpoint.model.events.eventSelectorTypes;

/**
* Specifies the type of identifier used to select an custom event.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifies the type of identifier used to select a custom event.

...com/simplito/java/privmx_endpoint/model/events/eventSelectorTypes/KvdbEventSelectorType.java Outdated


/**
* Specifies the type of identifier used to select an KVDB event.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifies the type of identifier used to select a KVDB event.

...om/simplito/java/privmx_endpoint/model/events/eventSelectorTypes/StoreEventSelectorType.java Outdated
package com.simplito.java.privmx_endpoint.model.events.eventSelectorTypes;

/**
* Specifies the type of identifier used to select an store event.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifies the type of identifier used to select a store event.

...m/simplito/java/privmx_endpoint/model/events/eventSelectorTypes/ThreadEventSelectorType.java Outdated
package com.simplito.java.privmx_endpoint.model.events.eventSelectorTypes;

/**
* Specifies the type of identifier used to select an thread event.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifies the type of identifier used to select a thread event.

privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/modules/inbox/InboxApi.java Outdated

/**
* Subscribes for events in given Inbox.
* Unsubscribe from events for the given subscriptionId.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsubscribe from events with the given subscriptionId.

privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/modules/kvdb/KvdbApi.java Outdated
* Generate subscription Query for the KVDB events.
*
* @param kvdbId ID of the KVDB to unsubscribe
* @param eventType type of event which you listen for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type of event you listen for

privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/modules/store/StoreApi.java Outdated

/**
* Unsubscribes from the Store module main events.
* Unsubscribe from events for the given subscriptionId.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsubscribe from events with the given subscriptionId.

privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/modules/store/StoreApi.java Outdated
* Generate subscription Query for the Store events.
*
* @param storeId ID of the {@code Store} to unsubscribe
* @param eventType type of event which you listen for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type of event you listen for

privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/modules/thread/ThreadApi.java Outdated

/**
* Unsubscribes from the Thread module main events.
* Unsubscribe from events for the given subscriptionId.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsubscribe from events with the given subscriptionId.

privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/modules/thread/ThreadApi.java Outdated
* Generate subscription Query for the Thread events.
*
* @param threadId ID of the Thread to unsubscribe
* @param eventType type of event which you listen for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type of event you listen for

@djenczewski djenczewski requested a review from filipg43 September 9, 2025 13:01
@djenczewski djenczewski merged commit 88631d2 into feat/implement-2.6 Sep 9, 2025
@djenczewski djenczewski deleted the feat/implement-builders-and-enums-for-subscription-queries branch September 9, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurekz zurekz zurekz approved these changes

@djenczewski djenczewski djenczewski approved these changes

@filipg43 filipg43 filipg43 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Doominika @zurekz @djenczewski @filipg43