Enhance performance and memory efficiency #1414
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomorgado
force-pushed
the
memory1
branch
3 times, most recently
from
66a312e to
5268254
Compare
Enhanced performance and memory efficiency throughout the SIPSorcery project by replacing traditional byte array handling with Span<byte> and ReadOnlySpan<byte> in multiple components, including RTCP, SCTP, and AudioEncoder classes. Refactored packet parsing and serialization logic using BinaryPrimitives for endian conversions, and updated NetConvert accordingly. Introduced utility methods in EncodingExtensions, TypeExtensions, BinaryOperations, and MemoryOperations to streamline string, byte array, and endian-aware operations. Marked legacy methods as obsolete to guide migration to span-based APIs. Updated SIPSorcery.csproj to include System.Memory and Microsoft.Bcl.HashCode packages, and enabled AllowUnsafeBlocks for performance-critical code paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds methods that use
ReadOnlySpan<byte>/Span<byte>instead ofbyte[]and replacesbyte[]enumeration and LINQSkipandTakeoperations with span operations.This allows callers to have complete ownership of the memory and use pooled memory.
Not being a complete solution, it already achieves some level of reducing allocations and memory copying and constitutes ground work for applying this across the library.
Some normalization of reading and writing bytes using
BinaryPrimitives. This can be improved by creating helper methods that read/write and advance to make the code more readable and error prone, but I left that for later.