Skip to content

Conversation

barakshechter
Copy link

@barakshechter barakshechter commented Dec 3, 2019

Moving the type dependencies to devDependencies since the compiled index.js has no direct need for them. The only hard dependency this library needs is cls-hooked.

@coveralls
Copy link

coveralls commented Dec 3, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 74da837 on barakshechter:move-type-deps-to-dev-only into f6b63dc on skonves:master.

@barakshechter
Copy link
Author

Hi @skonves ,

I was depending on your library when I noticed it had a hard dependency on express types, which theoretically only apply when developing in typescript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants