Skip to content

Conversation

sergerad
Copy link

No description provided.

@grs
Copy link
Member

grs commented Jan 29, 2020

I would rather leave the connect() with no args and rely on file based configuration as it makes things much easier to configure. You can add a connect.json to the current directory or to /etc/messaging that contains the hostname, port, tls and/or user credentials that way. Will that work for you?

@sergerad
Copy link
Author

I would rather leave the connect() with no args and rely on file based configuration as it makes things much easier to configure. You can add a connect.json to the current directory or to /etc/messaging that contains the hostname, port, tls and/or user credentials that way. Will that work for you?

Makes sense - I didn't notice the config file approach. Would you like the commit that updates package.json and adds package-lock.json? I can update the PR if so. I couldn't npm install the project without the added dep in package.json.

@grs
Copy link
Member

grs commented Jan 30, 2020

I couldn't npm install the project without the added dep in package.json.

What version of npm are you using? The docker file runs npm install to create the image which is working fine (though with a somewhat old node version).

@sergerad
Copy link
Author

sergerad commented Feb 3, 2020

v10.16.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants