Refactor: updates after interim audit report #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the issue with the `wait` modifier from `MCD_PAUSE`
Co-authored-by: oddaf <[email protected]>
…quidationAmount - Use generic "debt" terminology instead of specific "DAI" references - Update function name in library, tests, and documentation - Update parameter descriptions to use "debt units" instead of "DAI" This change makes the library more token-agnostic by replacing specific token references with generic terms, improving flexibility for Sky Protocol.
- Update function name in library, tests, and documentation - Update parameter descriptions to use generic terminology - Replace specific DAI references with generic stablecoin terminology This change makes the library more token-agnostic by using generic terminology, improving flexibility for Sky Protocol.
- Replace 'DAI' with generic terminology in parameter descriptions - Use generic 'amount' instead of 'DAI amount' throughout - Clarify RWA documentation with note about DAI support - Make documentation more token-agnostic This change continues the effort to make the library more generic and adaptable for different token implementations.
- Add overloaded function to set amount and gap while preserving TTL - Add test helper in MockDssSpellAction.sol - Add test case in DssAction.t.sol to verify TTL is preserved - Update README.md with documentation for the new function This change allows for more convenient parameter updates when only the amount and gap need to be modified without changing the TTL.
Co-authored-by: oddaf <[email protected]>
Co-authored-by: oddaf <[email protected]>
… gap)` Ensure this overload only works if the ilk has been properly configured before.
Update tests to stop using ilks and pips that have been off-boarded
0xdecr1pto
approved these changes
Sep 16, 2025
oddaf
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flipperMomgettersetAutoLineIlkParameters(ilk, amount, gap)