Skip to content

[WIP] Make the bottom nav sample adaptive #2225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 27 commits into
base: j-compose-110
Choose a base branch
from
Draft

[WIP] Make the bottom nav sample adaptive #2225

wants to merge 27 commits into from

Conversation

@stagg
Copy link
Collaborator

@stagg stagg commented Aug 6, 2025 •
edited
Loading

Changes

Adaptive

  • WIP, updating some stashed progress for showing content side-by-side on with a specialized nav decoration
  • Want to generalize this a bit more and pull out the boilerplate helpers

Slide over

  • Works way better with a forward history stack
  • Need to fix the animation setup so an item correctly moves around
  • Current work-in-progress to support this

stagg added 22 commits August 5, 2025 18:19
@stagg
Add a detail screen
c453e48
@stagg
Rework the content layout to be adaptive
9dde251
@stagg
Fix root reset
500a45d
@stagg
Merge branch 'main' into j-sample-bottombar-adaptive
30c6a24
@stagg
Get it mostly working with ListDetailPaneScaffold
303c8d8
@stagg
wip swipe to restore thing, trying a backstack record stash thing
18c5475
@stagg
WIP - Better approach by preventing the backstack pop
5693ede 
- Need to have the item/detail layout handle the "closed" two item layout
directly, allows for resizing animation
- Provide a "decorator" shared element scope
@stagg
Merge branch 'main' into j-sample-bottombar-adaptive
df23f8c
@stagg
Merge remote-tracking branch 'origin/main' into j-sample-bottombar-ad…
bb4d5dc 
…aptive
@stagg
merge fixes
5634d63
@stagg
Add navigator as a param on the AnimatedNavDecorator.Factory create
e2f58bd
@stagg
Make AdaptiveNavDecoration just be concerned with the ListDetail la…
59b39fa 
…yout
@stagg
gitignore
8df817e
@stagg
retain pane position
e2fd5f0
@stagg
tidy up
0406398
@stagg
figure out some slide over stuff
d7a7015
@stagg
Merge branch 'main' into j-sample-bottombar-adaptive
1b53545
@stagg
navstack
87b0ba4
@stagg
Actual SaveableNavStack implementation
33e22ab
@stagg
NavStack everywhere
121dbd7
@stagg
Merge branch 'j-compose-110' into j-sample-bottombar-adaptive
5994879
@stagg
Start wiring into NavEventHandler
48bd6f1
@stagg stagg changed the base branch from main to j-compose-110 November 14, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stagg