Skip to content

chore: Update TODO comments #4150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Update TODO comments #4150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5dd32f
chore: Update TODO comments
ianlewis Mar 19, 2025
e972734
Merge branch 'main' into 1110-release-docs
ianlewis Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,9 @@ End-to-end tests run daily in [github.com/slsa-framework/example-package/.github
"$GH" release -R slsa-framework/slsa-github-generator upload "$BUILDER_TAG" slsa-builder-go-linux-amd64 --clobber
```

6. Re-run the workflow above and verify that it succeeds. (TODO: https://github.com/slsa-framework/slsa-github-generator/issues/116).
6. Re-run the workflow above and verify that it succeeds.

<!-- TODO(#116): Automate pre-release steps. -->

If it does not, delete the release, fix the bug and re-start the release process at the top of this page.

Expand Down Expand Up @@ -374,7 +376,9 @@ End-to-end tests run daily in [github.com/slsa-framework/example-package/.github
"$GH" release -R slsa-framework/slsa-github-generator upload "$BUILDER_TAG" slsa-generator-generic-linux-amd64 --clobber
```

6. Re-run the workflow above and verify that it succeeds. (TODO: https://github.com/slsa-framework/slsa-github-generator/issues/116).
6. Re-run the workflow above and verify that it succeeds.

<!-- TODO(#116): Automate pre-release steps. -->

If it does not, delete the release, fix the bug and re-start the release process at the top of this page.

Expand Down Expand Up @@ -417,7 +421,9 @@ End-to-end tests run daily in [github.com/slsa-framework/example-package/.github
"$GH" release -R slsa-framework/slsa-github-generator upload "$BUILDER_TAG" slsa-generator-container-linux-amd64 --clobber
```

6. Re-run the workflow above and verify that it succeeds. (TODO: https://github.com/slsa-framework/slsa-github-generator/issues/116).
6. Re-run the workflow above and verify that it succeeds.

<!-- TODO(#116): Automate pre-release steps. -->

If it does not, delete the release, fix the bug and re-start the release process at the top of this page.

Expand Down Expand Up @@ -460,7 +466,9 @@ End-to-end tests run daily in [github.com/slsa-framework/example-package/.github
"$GH" release -R slsa-framework/slsa-github-generator upload "$BUILDER_TAG" slsa-builder-docker-linux-amd64 --clobber
```

6. Re-run the workflow above and verify that it succeeds. (TODO: https://github.com/slsa-framework/slsa-github-generator/issues/116).
6. Re-run the workflow above and verify that it succeeds.

<!-- TODO(#116): Automate pre-release steps. -->

If it does not, delete the release, fix the bug and re-start the release process at the top of this page.

Expand Down Expand Up @@ -557,8 +565,6 @@ find actions/maven/ internal/builders/maven/ -name '*.yaml' -o -name '*.yml' -ty

The next step is to update the verifier's GitHub Actions e2e tests. There are GitHub actions Go and generic actions.

<!-- TODO(github.com/slsa-framework/slsa-github-generator/issues/1110): Describe GHA generic container e2e tests. -->

For the BYOB (a.k.a delegator) workflows, you will need to update the tag of the [slsa-framework/example-trw](https://github.com/slsa-framework/example-trw/) repository:

1. Update the references to the tag and send a PR:
Expand Down
Loading