Skip to content

Conversation

@connorwstein
Copy link
Contributor

@connorwstein connorwstein commented Oct 8, 2025

Notes

  • Adds helpers for creating EVM transaction keys and EVM OCR onchain keyrings on top of the new base keystore library Includes a test with real libocr to ensure the keys/keyrings function. Example usage:
	ks, err := keystore.LoadKeystore(ctx, storage, "test-password", commonks.WithScryptParams(commonks.FastScryptParams))
	require.NoError(t, err)
	testKey, err := evmks.CreateTxKey(ks, "test-tx-key")
	require.NoError(t, err)
	resp, err := testKey.SignTx(ctx, evmks.SignTxRequest{
		ChainID: big.NewInt(1337), // Use a test chain ID
		Tx:      testTransaction,
	})
	require.NoError(t, err)
	require.NoError(t, backend.Client().SendTransaction(ctx, resp.Tx))
  • Points to latest chainlink-common which includes a golang version bump to 1.25, which required the v2 linter version. As per @chainchad's rec switched to using the common/standard one instead so we could remove the custom one here (but we can override it again if needed).

@connorwstein connorwstein marked this pull request as ready for review November 7, 2025 20:30
@connorwstein connorwstein requested review from a team and dimriou as code owners November 7, 2025 20:30
t.backendMutex.Lock()
defer t.backendMutex.Unlock()

t.lggr.Info("Transmit", "report", report)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't you be able to reuse

func (oc *dualContractTransmitter) Transmit(ctx context.Context, reportCtx ocrtypes.ReportContext, report ocrtypes.Report, signatures []ocrtypes.AttributedOnchainSignature) error {
?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't look like it - that struct has many other dependencies (logpoller etc.)

@connorwstein connorwstein merged commit 9abb555 into develop Nov 13, 2025
33 checks passed
@connorwstein connorwstein deleted the ARCH-334-evm-support branch November 13, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants