feat(ops): Add MCMS to Ramp Operations #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigombsoares
force-pushed
the
mcms-e2e-tests-ramps
branch
2 times, most recently
from
26b1bbe to
8c458c6
Compare
rodrigombsoares
commented
Oct 27, 2025
Comment on lines
95
to
97
| // TODO: this print is probably unintended | ||
| // jsonbytes, _ := json.MarshalIndent(proposalInput, "", " ") | ||
| // fmt.Println("Accept CCIP Ownership Proposal Input: ", string(jsonbytes)) |
There was a problem hiding this comment.
cc: @RodrigoAD can I remove this print?
There was a problem hiding this comment.
Yes, we can and we should. Lint is somehow not catching this...
RodrigoAD
previously approved these changes
Oct 27, 2025
rodrigombsoares
force-pushed
the
mcms-e2e-tests-ramps
branch
from
a2c4012 to
26610f4
Compare
RodrigoAD
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds tests for OnRamp and OffRamp via MCMS.
Features
vector<vector<address>>ontype_converter.go