Skip to content

Add Missing Dependencies In Codegen #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2025
Merged

Add Missing Dependencies In Codegen #557

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e5f7f1
Add missing smithy-json and smithy-aws-event-stream dependencies
jonathan343 Sep 15, 2025
cf8840c
Add optional 'json' dependency
jonathan343 Sep 16, 2025
56a811e
Include optional dependencies on 'eventstream' and 'json' for smithy-…
jonathan343 Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions codegen/core/src/main/java/software/amazon/smithy/python/codegen/ClientGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ raise ExpectationNotMetError("protocol and transport MUST be set on the config t
private void generateEventStreamOperation(PythonWriter writer, OperationShape operation) {
writer.pushState(new OperationSection(service, operation));
writer.addDependency(SmithyPythonDependency.SMITHY_CORE);
writer.addDependency(SmithyPythonDependency.SMITHY_AWS_EVENT_STREAM);
var operationSymbol = symbolProvider.toSymbol(operation);
writer.putContext("operation", operationSymbol);
var operationMethodSymbol = operationSymbol.expectProperty(OPERATION_METHOD);
Expand Down
1 change: 1 addition & 0 deletions ...in/java/software/amazon/smithy/python/codegen/integrations/RestJsonProtocolGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ public ApplicationProtocol getApplicationProtocol(GenerationContext context) {
@Override
public void initializeProtocol(GenerationContext context, PythonWriter writer) {
writer.addDependency(SmithyPythonDependency.SMITHY_AWS_CORE);
writer.addDependency(SmithyPythonDependency.SMITHY_JSON);
writer.addImport("smithy_aws_core.aio.protocols", "RestJsonClientProtocol");
var serviceSymbol = context.symbolProvider().toSymbol(context.settings().service(context.model()));
var serviceSchema = serviceSymbol.expectProperty(SymbolProperties.SCHEMA);
Expand Down
Loading