-
Notifications
You must be signed in to change notification settings - Fork 35
feat!: Schema-based serialization #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jbelkins
wants to merge
38
commits into
main
Choose a base branch
from
jbe/sbs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 11 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
3a91aac
WIP, schemas compile
jbelkins c754545
Protocol tests compile
jbelkins 1063698
Full SDK compiled
jbelkins e2df562
All but 9 protocol tests pass
jbelkins b5708e9
Schema simplified, some tests failing
jbelkins 72efe11
9 protocol test fails
jbelkins e8e3fd2
Merge branch 'main' into jbe/sbs
jbelkins 37f013c
All protocol tests pass
jbelkins 2e9ef4e
Remove Unit associated type from union members, provide prelude schemas
jbelkins 1dbd2a2
Replace DeserializableShape with factory block
jbelkins 704fae4
Codegen cleanup
jbelkins 13bf7f7
Fix codegen tests & lint
jbelkins b29d75b
Merge branch 'main' into jbe/sbs
jbelkins aabbad7
Eliminate enum & int enum member schemas
jbelkins 086b99a
Fix ktlint
jbelkins bd9bfdf
Clean up respectsJSONName propagation
jbelkins 8ba8b28
Merge branch 'main' into jbe/sbs
jbelkins a833881
Revert SwiftWriter changes
jbelkins 5721d02
Remove default value from endpoint generator
jbelkins 4636512
Merge branch 'main' into jbe/sbs
jbelkins 9c4d161
Merge branch 'main' into jbe/sbs
jbelkins 34de074
Merge branch 'main' into jbe/sbs
jbelkins 9d4cb51
Merge remote-tracking branch 'origin/main' into jbe/sbs
jbelkins eee76b0
Merge remote-tracking branch 'origin/main' into jbe/sbs
jbelkins c4dd341
Merge branch 'main' into jbe/sbs
jbelkins 93fe720
Merge branch 'main' into jbe/sbs
jbelkins c68c761
Merge branch 'main' into jbe/sbs
jbelkins b65a726
Merge branch 'main' into jbe/sbs
jbelkins a05990a
Fix build, run ktlint
jbelkins 69469d2
Merge branch 'main' into jbe/sbs
jbelkins 7d00770
Merge branch 'main' into jbe/sbs
jbelkins f0ed0e2
Fix NullDocument protocol tests
jbelkins 4da3b59
fix ktlint
jbelkins 7d694a0
Merge branch 'main' into jbe/sbs
jbelkins e6e0d27
Merge remote-tracking branch 'origin/main' into jbe/sbs
jbelkins 1048017
Convert traits to free-form
jbelkins 207921b
Cleanup
jbelkins ed8312b
Moved Node to Smithy module
jbelkins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
274 changes: 274 additions & 0 deletions
274
Sources/SmithyJSON/Reader/Reader+ShapeDeserializer.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,274 @@ | ||
// | ||
// Copyright Amazon.com Inc. or its affiliates. | ||
// All Rights Reserved. | ||
// | ||
// SPDX-License-Identifier: Apache-2.0 | ||
// | ||
|
||
import struct Foundation.Data | ||
import struct Foundation.Date | ||
import struct Foundation.TimeInterval | ||
import struct Smithy.Document | ||
import protocol Smithy.SmithyDocument | ||
import enum SmithyReadWrite.ReaderError | ||
@_spi(SmithyReadWrite) import protocol SmithyReadWrite.ShapeDeserializer | ||
@_spi(SmithyReadWrite) import protocol SmithyReadWrite.SchemaProtocol | ||
@_spi(SmithyReadWrite) import struct SmithyReadWrite.Schema | ||
@_spi(SmithyTimestamps) import enum SmithyTimestamps.TimestampFormat | ||
|
||
@_spi(SmithyReadWrite) | ||
extension Reader: SmithyReadWrite.ShapeDeserializer { | ||
|
||
public func readStructure<Target>(schema: SmithyReadWrite.Schema<Target>) throws -> Target? { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
let structureSchema = resolvedTargetSchema(schema: schema) | ||
guard let factory = structureSchema.factory else { | ||
throw SmithyReadWrite.ReaderError.invalidSchema("Missing factory for structure or union: \(structureSchema.id)") | ||
} | ||
guard resolvedReader.hasContent, resolvedReader.jsonNode == .object else { | ||
return resolvedDefault(schema: schema) != nil ? factory() : nil | ||
} | ||
var value = factory() | ||
try structureSchema.members.forEach { memberContainer in | ||
try memberContainer.performRead(base: &value, key: "", reader: resolvedReader) | ||
} | ||
return value | ||
} | ||
|
||
public func readList<T>(schema: Schema<[T]>) throws -> [T]? { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
guard resolvedReader.hasContent, resolvedReader.jsonNode == .array else { | ||
return resolvedDefault(schema: schema) != nil ? [] : nil | ||
} | ||
let listSchema = resolvedTargetSchema(schema: schema) | ||
guard let memberContainer = listSchema.members.first(where: { $0.member.memberSchema().memberName == "member" }) else { | ||
throw ReaderError.requiredValueNotPresent | ||
} | ||
var value = [T]() | ||
for child in resolvedReader.children { | ||
child.respectsJSONName = respectsJSONName | ||
try memberContainer.performRead(base: &value, key: "", reader: child) | ||
} | ||
return value | ||
} | ||
|
||
public func readMap<T>(schema: Schema<[String: T]>) throws -> [String : T]? { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
guard resolvedReader.hasContent, resolvedReader.jsonNode == .object else { | ||
return resolvedDefault(schema: schema) != nil ? [:] : nil | ||
} | ||
let mapSchema = resolvedTargetSchema(schema: schema) | ||
guard let valueContainer = mapSchema.members.first(where: { $0.member.memberSchema().memberName == "value" }) else { | ||
throw ReaderError.requiredValueNotPresent | ||
} | ||
var value = [String: T]() | ||
for child in resolvedReader.children { | ||
child.respectsJSONName = respectsJSONName | ||
if !mapSchema.isSparse && child.jsonNode == .null { continue } | ||
try valueContainer.performRead(base: &value, key: child.nodeInfo.name, reader: child) | ||
} | ||
return value | ||
} | ||
|
||
public func readEnum<T: RawRepresentable>(schema: Schema<T>) throws -> T? where T.RawValue == String { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
guard resolvedReader.hasContent, case .string = resolvedReader.jsonNode else { | ||
return try resolvedDefault(schema: schema).map { T(rawValue: try $0.asString())! } | ||
} | ||
let enumSchema = resolvedTargetSchema(schema: schema) | ||
guard let rawValue: String = try resolvedReader.readIfPresent() else { return nil } | ||
for memberContainer in enumSchema.members { | ||
guard let resolvedEnumValue = try memberContainer.member.memberSchema().enumValue?.asString() ?? memberContainer.member.memberSchema().memberName else { | ||
throw ReaderError.requiredValueNotPresent | ||
} | ||
if rawValue == resolvedEnumValue { | ||
return T(rawValue: rawValue) | ||
} | ||
} | ||
return T(rawValue: rawValue) | ||
} | ||
|
||
public func readIntEnum<T: RawRepresentable>(schema: Schema<T>) throws -> T? where T.RawValue == Int { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
guard resolvedReader.hasContent, case .number = resolvedReader.jsonNode else { | ||
return try resolvedDefault(schema: schema).map { T(rawValue: try $0.asInteger())! } | ||
} | ||
guard let rawValue: Int = try resolvedReader.readIfPresent() else { return nil } | ||
for memberContainer in resolvedTargetSchema(schema: schema).members { | ||
guard let resolvedEnumValue = try memberContainer.member.memberSchema().enumValue?.asInteger() else { | ||
throw ReaderError.requiredValueNotPresent | ||
} | ||
if rawValue == resolvedEnumValue { | ||
return T(rawValue: rawValue) | ||
} | ||
} | ||
return T(rawValue: rawValue) | ||
} | ||
|
||
public func readString(schema: Schema<String>) throws -> String? { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
guard resolvedReader.hasContent, case .string = resolvedReader.jsonNode else { | ||
return try resolvedDefault(schema: schema)?.asString() | ||
} | ||
return try resolvedReader.readIfPresent() | ||
} | ||
|
||
public func readBoolean(schema: SmithyReadWrite.Schema<Bool>) throws -> Bool? { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
guard resolvedReader.hasContent, case .bool = resolvedReader.jsonNode else { | ||
return try resolvedDefault(schema: schema)?.asBoolean() | ||
} | ||
return try resolvedReader.readIfPresent() | ||
} | ||
|
||
public func readByte(schema: SmithyReadWrite.Schema<Int8>) throws -> Int8? { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
guard resolvedReader.hasContent, case .number = resolvedReader.jsonNode else { | ||
return try resolvedDefault(schema: schema)?.asByte() | ||
} | ||
return try resolvedReader.readIfPresent() | ||
} | ||
|
||
public func readShort(schema: SmithyReadWrite.Schema<Int16>) throws -> Int16? { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
guard resolvedReader.hasContent, case .number = resolvedReader.jsonNode else { | ||
return try resolvedDefault(schema: schema)?.asShort() | ||
} | ||
return try resolvedReader.readIfPresent() | ||
} | ||
|
||
public func readInteger(schema: SmithyReadWrite.Schema<Int>) throws -> Int? { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
guard resolvedReader.hasContent, case .number = resolvedReader.jsonNode else { | ||
return try resolvedDefault(schema: schema)?.asInteger() | ||
} | ||
return try resolvedReader.readIfPresent() | ||
} | ||
|
||
public func readLong(schema: SmithyReadWrite.Schema<Int>) throws -> Int? { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
guard resolvedReader.hasContent, case .number = resolvedReader.jsonNode else { | ||
return try resolvedDefault(schema: schema)?.asInteger() | ||
} | ||
return try resolvedReader.readIfPresent() | ||
} | ||
|
||
public func readFloat(schema: SmithyReadWrite.Schema<Float>) throws -> Float? { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
guard resolvedReader.hasContent else { | ||
return try resolvedDefault(schema: schema)?.asFloat() | ||
} | ||
return try resolvedReader.readIfPresent() | ||
} | ||
|
||
public func readDouble(schema: SmithyReadWrite.Schema<Double>) throws -> Double? { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
guard resolvedReader.hasContent else { | ||
return try resolvedDefault(schema: schema)?.asDouble() | ||
} | ||
return try resolvedReader.readIfPresent() | ||
} | ||
|
||
public func readBigInteger(schema: SmithyReadWrite.Schema<Int64>) throws -> Int64? { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
guard resolvedReader.hasContent, case .number = resolvedReader.jsonNode else { | ||
return try resolvedDefault(schema: schema)?.asBigInteger() | ||
} | ||
let int: Int? = try resolvedReader.readIfPresent() | ||
return int.map { Int64($0) } | ||
} | ||
|
||
public func readBigDecimal(schema: SmithyReadWrite.Schema<Double>) throws -> Double? { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
guard resolvedReader.hasContent else { | ||
return try resolvedDefault(schema: schema)?.asDouble() | ||
} | ||
return try resolvedReader.readIfPresent() | ||
} | ||
|
||
public func readBlob(schema: SmithyReadWrite.Schema<Data>) throws -> Data? { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
guard resolvedReader.hasContent, case .string = resolvedReader.jsonNode else { | ||
guard let base64String = try resolvedDefault(schema: schema)?.asString() else { return nil } | ||
return Data(base64Encoded: base64String) | ||
} | ||
return try resolvedReader.readIfPresent() | ||
} | ||
|
||
public func readTimestamp(schema: SmithyReadWrite.Schema<Date>) throws -> Date? { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
guard resolvedReader.hasContent else { | ||
guard let defaultValue = resolvedDefault(schema: schema) else { return nil } | ||
switch defaultValue.type { | ||
case .float: | ||
let interval = try TimeInterval(defaultValue.asFloat()) | ||
return Date(timeIntervalSince1970: interval) | ||
case .double: | ||
return try Date(timeIntervalSince1970: defaultValue.asDouble()) | ||
case .timestamp: | ||
return try defaultValue.asTimestamp() | ||
default: | ||
throw SmithyReadWrite.ReaderError.invalidSchema("Unsupported timestamp default type: \(defaultValue.type)") | ||
} | ||
} | ||
let memberSchema = schema.type == .member ? schema : nil | ||
let timestampSchema = schema.targetSchema() ?? schema | ||
let resolvedTimestampFormat = memberSchema?.timestampFormat ?? timestampSchema.timestampFormat | ||
return try resolvedReader.readTimestampIfPresent(format: resolvedTimestampFormat ?? .epochSeconds) | ||
} | ||
|
||
public func readDocument(schema: SmithyReadWrite.Schema<Document>) throws -> Document? { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
guard resolvedReader.hasContent else { | ||
return resolvedDefault(schema: schema).map { Document($0) } | ||
} | ||
return try resolvedReader.readIfPresent() | ||
} | ||
|
||
public func readNull(schema: any SmithyReadWrite.SchemaProtocol) throws -> Bool? { | ||
let resolvedReader = try resolvedReader(schema: schema) | ||
guard resolvedReader.hasContent, case .null = resolvedReader.jsonNode else { | ||
return false | ||
} | ||
return try resolvedReader.readIfPresent() | ||
} | ||
|
||
private func resolvedReader(schema: any SchemaProtocol) throws -> Reader { | ||
if schema.httpPayload { | ||
return self | ||
} else if schema.containerType == .map || schema.containerType == .list || schema.containerType == .set { | ||
return self | ||
} else if schema.type == .member { | ||
let resolvedName = try resolvedName(memberSchema: schema) | ||
return self[NodeInfo(resolvedName)] | ||
} else { | ||
return self | ||
} | ||
} | ||
|
||
private func resolvedDefault<Target>(schema: Schema<Target>) -> (any SmithyDocument)? { | ||
if schema.type == .member { | ||
return schema.defaultValue ?? schema.targetSchema()?.defaultValue | ||
} else { | ||
return schema.defaultValue | ||
} | ||
} | ||
|
||
private func resolvedTargetSchema<Target>(schema: Schema<Target>) -> Schema<Target> { | ||
schema.targetSchema() ?? schema | ||
} | ||
|
||
private func resolvedName(memberSchema: any SchemaProtocol) throws -> String { | ||
if respectsJSONName { | ||
guard let resolvedName = memberSchema.jsonName ?? memberSchema.memberName else { | ||
throw ReaderError.requiredValueNotPresent | ||
} | ||
return resolvedName | ||
} else { | ||
guard let resolvedName = memberSchema.memberName else { | ||
throw ReaderError.requiredValueNotPresent | ||
} | ||
return resolvedName | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.