-
Notifications
You must be signed in to change notification settings - Fork 36
feat: adding image for mastodon posts #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughUpdates the GitHub Actions workflow for release announcements: adjusts the push trigger to use paths, adds a checkout step before posting, and extends the Mastodon posting step with image and description inputs. Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub
participant WF as Workflow: announce-release
participant ST1 as Step: Checkout (actions/checkout@v4)
participant ST2 as Step: Mastodon Post
GH->>WF: Push to default branch with paths: CHANGELOG.md
activate WF
WF->>ST1: Run checkout
note right of ST1: Newly added step to fetch repo content
ST1-->>WF: Repository files available
WF->>ST2: Post release to Mastodon
note right of ST2: Extended with image and image-description inputs
ST2-->>WF: Status (success/failure)
WF-->>GH: Job completed
deactivate WF
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
.github/workflows/announce-release.yml (2)
10-12
: Checkout will fail withoutcontents: read
permission.Defining any
permissions
block disables other defaults;actions/checkout
needscontents: read
. Add it.Apply:
permissions: - pull-requests: read + contents: read + pull-requests: read
21-44
: Pin Mastodon action, validate image asset, & fix missing step
- Pin
snakemake/mastodon-release-post-action
to a specific tag or commit SHA instead of@main
(announce-release.yml line 22).- Add a
test -f pr_logo/long_logo_hpc.png
check immediately after checkout to fail early if the image is missing.- Remove or correct the reference to
steps.extract-release-notes.outputs.release_notes
—no such step exists in this workflow.- The action already supports the
pr-title
input, so defining aPR_TITLE
env var is unnecessary.- Optional: enhance
image-description
for better accessibility.
🧹 Nitpick comments (1)
.github/workflows/announce-release.yml (1)
18-20
: Trim trailing whitespace.YAMLlint flags trailing spaces on Line 20.
Apply:
- +
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pr_logo/long_logo_hpc.png
is excluded by!**/*.png
📒 Files selected for processing (1)
.github/workflows/announce-release.yml
(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: cmeesters
PR: snakemake/snakemake-executor-plugin-slurm#187
File: .github/workflows/post_to_mastodon.yml:0-0
Timestamp: 2025-01-17T17:27:32.446Z
Learning: In the mastodon publishing workflow for snakemake-executor-plugin-slurm, the PR_TITLE environment variable is required by the post_to_mastodon.sh script and should be preserved.
🪛 YAMLlint (1.37.1)
.github/workflows/announce-release.yml
[error] 20-20: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: testing
🔇 Additional comments (1)
.github/workflows/announce-release.yml (1)
7-8
: Good fix: use the correct push filter keypaths
.
paths
(plural) is the supported key for path filters on push.
Summary by CodeRabbit
New Features
Chores