-
Notifications
You must be signed in to change notification settings - Fork 527
Separate server and redirect URIs in AuthHttpServer
#2400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Separate server and redirect URIs in AuthHttpServer
#2400
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
| uri=os.environ.get("SNOWFLAKE_OAUTH_SOCKET_ADDRESS", "http://localhost") | ||
| + ":" | ||
| + os.environ.get("SNOWFLAKE_OAUTH_SOCKET_PORT", "0"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't we use an f string here?
|
@npeshkov thanks for the PR. Have you tested the code in some kind of cloud ide? |
Hi @sfc-gh-turbaszek I have tested in a Cloud IDE and locally. Happy to test again |
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2194055: AuthServer listens on redirect URI instead of localhost during OAuth Code flow #2396
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Allowing redirect URI to be different from server URI allows users to provide non-localhost redirect URIs (common in cloud IDEs) without preventing the server to start up on localhost.
localhost) local redirect URI, e.g.http://myhostwon't be able to authenticate unless they set their custom server address and port env variables.Note: I couldn't run integration and auth tests locally, would need you help with that.