Bump snowplow-common-enrich to 3.8.0 (close #138) #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @stanch ,
In #139 I started to replace
IdwithIObecause it won't be possible to useIdwith Enrich any more (along with Stream Enrich deprecation), but there is no need to spend time on it now (it requires some refactoring in Micro) as next Enrich release is not ready yet, so I just bumped Enrich to3.8.0like you wanted to initially.The reason why you had the issue with
CreateSqlQueryEnrichment[Id]is that it requires to haveClock[Id]implicitly available, but it was not.(I didn't see a
developbranch, feel free to change the PR to what you suits you)