fix: zerolog error caused by scrubbingLogWriter #403
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
j-luong
force-pushed
the
fix/cli-979_scrubbingLogger
branch
2 times, most recently
from
92219cd to
0215ac3
Compare
| @@ -308,30 +308,24 @@ func TestAddDefaults(t *testing.T) { | |||
| password: 'password-set', | |||
| 'password=foobar': true, | |||
| 'u=foobar': true, | |||
| 'password-with-double-quotes=foo"bar': true, | |||
There was a problem hiding this comment.
removed some of the tests cases as they seemed unrealistic (e.g. they contained unusual characters like '," in passwords) and was causing edge cases that the regex cannot capture fully.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
j-luong
force-pushed
the
fix/cli-979_scrubbingLogger
branch
from
0215ac3 to
16af22f
Compare
| } | ||
|
|
||
| // Additional pattern for the specific case: 'key=value': true | ||
| s = fmt.Sprintf(`(?im)['"]([^'"\s,}]*?(?:%s)[^'"\s,}]*?=)([^'"\s,}]*?)['"]`, kws) |
There was a problem hiding this comment.
Bug: Scrubbing Logic Flaws: Incomplete, Overzealous, Misdirected Redaction
The updated scrubbing logic has a few issues: it incompletely redacts sensitive values containing spaces, over-scrubs OAuth tokens by including non-sensitive trailing characters, and incorrectly redacts non-sensitive field values when their field name contains a sensitive keyword.
Additional Locations (1)
No description provided.