Skip to content

Fix incorrect block structure in queues example #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix incorrect block structure in queues example #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion context/best-practices.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ Async do |task|
while chunk = socket.gets
queue.push(chunk)
end
end

# After this point, we won't be able to add items to the queue, and popping items will eventually result in nil once all items are dequeued:
queue.close
end
Expand Down
2 changes: 1 addition & 1 deletion guides/best-practices/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ Async do |task|
while chunk = socket.gets
queue.push(chunk)
end
end
# After this point, we won't be able to add items to the queue, and popping items will eventually result in nil once all items are dequeued:
queue.close
end
Expand Down