Skip to content

feat: Improve buffer lifecycle handling in useBuffer hook #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Improve buffer lifecycle handling in useBuffer hook #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 5 additions & 21 deletions packages/typegpu-confetti/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,38 +28,22 @@ export function useBuffer<T extends AnyData>(
value?: Infer<T> | undefined,
): TgpuBuffer<T> {
const root = useRoot();
const bufferRef = useRef<TgpuBuffer<T> | null>(null);

// biome-ignore lint/correctness/useExhaustiveDependencies: <don't recreate buffer on value change>
let buffer = useMemo(() => {
if (bufferRef.current) {
bufferRef.current.destroy();
}
const buffer = root.createBuffer(schema, value);
bufferRef.current = buffer;
return buffer;
const buffer = useMemo(() => {
return root.createBuffer(schema);
}, [root, schema]);

// biome-ignore lint/style/noNonNullAssertion: <set in memo, strict mode acting weird>
buffer = bufferRef.current!;

useLayoutEffect(() => {
useEffect(() => {
if (value !== undefined && buffer && !buffer.destroyed) {
buffer.write(value);
}
}, [value, buffer]);

const cleanupRef = useRef<ReturnType<typeof setTimeout> | null>(null);

useEffect(() => {
if (cleanupRef.current !== null) {
clearTimeout(cleanupRef.current);
}

return () => {
cleanupRef.current = setTimeout(() => {
if (!buffer.destroyed) {
buffer.destroy();
}, 1000);
}
};
}, [buffer]);

Expand Down