Skip to content

Fix iPad RTL modal centering in RNSScreen #3326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix iPad RTL modal centering in RNSScreen #3326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ios/RNSScreen.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1725,6 +1725,19 @@ - (void)viewDidLayoutSubviews
}
#endif
}

if (self.screenView.isPresentedAsNativeModal) {
UIView *superview = self.view.superview;
if (superview != nil) {
// UIKit presents modals inside a UITransitionView. In RTL that container can be mirrored and
// report a negative origin. Copying the frame directly would offset the React view, so align
// it with the container's bounds to stay centered.
CGRect targetFrame = superview.bounds;
if (!CGRectEqualToRect(self.view.frame, targetFrame)) {
self.view.frame = targetFrame;
}
}
}
}

- (BOOL)isModalWithHeader
Expand Down