Skip to content

Conversation

@t0maboro
Copy link
Contributor

@t0maboro t0maboro commented Oct 23, 2025

Description

Update the logic of returned insets for SAV component used with the formSheet to define the available space on Android. From now on, the size of the formSheet is constrained by the maximum detent, and the content size equals the formSheet size with insets coming from systemBars or ime subtracted, depending on the test case.

Fixes: https://github.com/software-mansion/react-native-screens-labs/issues/457

Changes

  • Updated the logic for consuming insets in the SheetDelegate
  • Updated the definition of SheetBehavior for 3 detents - constraining the size with maxHeight
  • Added a new example for testing.

Screenshots / GIFs

Here you can add screenshots / GIFs documenting your change.

You can add before / after section if you're changing some behavior.

Before

before.mov

After

after.mov

Test code and steps to reproduce

Added Test3336 for testing.

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

@t0maboro t0maboro force-pushed the @t0maboro/form-sheet-flex-end branch from bb6e584 to 76ef71f Compare October 30, 2025 09:18
@t0maboro t0maboro changed the title fix(Android, FormSheet): Add SAV for defining formSheet bounds fix(Android, FormSheet): Fix formSheet - SafeAreaView integration Oct 30, 2025
@t0maboro t0maboro marked this pull request as ready for review October 30, 2025 09:52
@t0maboro t0maboro requested a review from kkafar October 30, 2025 09:53
@t0maboro t0maboro changed the title fix(Android, FormSheet): Fix formSheet - SafeAreaView integration fix(Android, Stack): Fix formSheet - SafeAreaView integration Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants