feat(Android, Tabs): add prop to hide the tab bar #3344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0maboro
reviewed
Oct 27, 2025
android/src/main/java/com/swmansion/rnscreens/gamma/tabs/TabsHostAppearanceApplicator.kt
Outdated
Show resolved
Hide resolved
t0maboro
approved these changes
Oct 27, 2025
kkafar
requested changes
Oct 29, 2025
| } | ||
|
|
||
| var tabBarHidden: Boolean by Delegates.observable(false) { _, oldValue, newValue -> | ||
| updateInterfaceInsets() |
There was a problem hiding this comment.
Why don't we diff here? oldValue & newValue can be the same. Let's check for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for
tabBarHiddenprop inTabsHost.Screen_recording_20251027_124939.mp4
Changes
tabBarHiddenprop on AndroidTest code and steps to reproduce
Run
TestBottomTabs, addtabBarHiddenprop, observe dynamic changes.Checklist