[WIP/PoC] NH-75342 refactor config and logging #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| logger.debug( | ||
| "Set up transaction filters: %s", | ||
| self.__config["transaction_filters"], |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
| else: | ||
| logger.warning( | ||
| "Ignore invalid configuration key: %s", | ||
| ".".join(keys), |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
| except (ValueError, TypeError): | ||
| logger.warning( | ||
| "Ignore config option with invalid (non-convertible or out-of-range) type: %s", | ||
| ".".join(keys if keys[0] != "transaction" else keys[1:]), |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
| with open(env_filepath, "x", encoding="utf-8") as env_file: | ||
| for config_key, config_value in self.__config.items(): | ||
| # TODO transactionSettings dumps | ||
| env_file.write(f"{config_key}={config_value}\n") |
Check failure
Code scanning / CodeQL
Clear-text storage of sensitive information
| apm_fwkv_manager = SolarWindsFrameworkKvManager() | ||
|
|
||
| # TODO Use to init/merge/?? with ApmConfig | ||
| user_config = extract_user_config() |
Check notice
Code scanning / CodeQL
Unused local variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP/PoC to split current ApmConfig into two parts init'd by distro then configurator.