Sample for enabling/disabling hardware sensors. #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjagnow
reviewed
Aug 11, 2022
| # Below is what the payload should look like: | ||
| payload_template = [ | ||
| {'HardwareInfoID': int, 'HardwareCategoryStatusID': int, 'UniqueName': str}, | ||
| ] |
There was a problem hiding this comment.
These 3 lines should be prefixed with # to make them part of the comment. We don't want to actually create payload_template.
There was a problem hiding this comment.
Good Suggestion. Commented out these lines.
| "SELECT NodeID, IPAddress " | ||
| "FROM Orion.Nodes " | ||
| f"WHERE IPAddress = '{ip_address}' " | ||
| )['results'][0]['NodeID'] |
There was a problem hiding this comment.
It might be useful to add a comment to explain that this sample assumes this query will return exactly one matching record.
There was a problem hiding this comment.
Good Suggestion. Added a comment to clarify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The payload for the verbs (Enable|Disable)Sensors was not straightforward. I spent a lot of time trolling thwack and swagger, trying to figure out how to format the payload to be used with orionsdk-python. Now that I have figured it out, I believe this information could be helpful to someone else.