Skip to content

Conversation

@katywings
Copy link
Contributor

@katywings katywings commented Sep 5, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Addresses an existing open issue: fixes #000
  • Tests for the changes have been added (for bug fixes / features)

Design Goals

  1. Consistency between dev/prod
  2. Prevent foucs
  3. Avoid unused route css
  4. Avoid duplicate css

Issues

  • Create an example for css testing
  • ?url imported css should not be server rendered
    • TODO: Needs a better way to detect ?url
  • <link> should be mounted before suspension-end during spa navigation
  • Suspension from spa navigation should only end after <link> has been loaded
  • Assets should be deduplicated on ssr
  • Integrate mountAssets in dev (making dev and prod use the same API)
  • Public manifest and asset mount API (Edit: Public manifest API analog to RFC: Client assets metadata API for SSR vitejs/vite#20913 will be implemented in a different branch)

Known problems:

  • 404 page is not server rendered
  • app.css gets removed when navigating from /index to /about in css-garden
  • <link> is mounted too early on spa navigation - it should wait until resources/createAsync is done

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2025

⚠️ No Changeset found

Latest commit: 27fef42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@katywings katywings marked this pull request as draft September 5, 2025 15:45
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 11, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@1965

commit: 27fef42

@katywings katywings force-pushed the devinxi-css branch 2 times, most recently from 7a38420 to 3974bd3 Compare September 17, 2025 16:11
@brenelz
Copy link
Contributor

brenelz commented Oct 24, 2025

This is still going to be post-devinxi into main?

@brenelz
Copy link
Contributor

brenelz commented Oct 24, 2025

bunch of conflicts now too

@katywings katywings force-pushed the devinxi-css branch 2 times, most recently from 7945276 to c9dd38e Compare October 25, 2025 13:34
@katywings
Copy link
Contributor Author

This is still going to be post-devinxi into main?

@brenelz It's still up for discussion of this is going straight into devinxi or if it is going into main. Why 😅?

@katywings
Copy link
Contributor Author

bunch of conflicts now too

@brenelz Just rebased it, conflicts are gone 😃. Next on my TODO list: rework the DEV part (try to render <link> in dev, instead of <style>).

@katywings katywings force-pushed the devinxi-css branch 5 times, most recently from f1aa3ef to 5518528 Compare October 26, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants