-
Notifications
You must be signed in to change notification settings - Fork 400
WIP: Devinxi css rework #1965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devinxi
Are you sure you want to change the base?
WIP: Devinxi css rework #1965
Conversation
|
470bfaf to
99196a1
Compare
commit: |
7a38420 to
3974bd3
Compare
3974bd3 to
e07865f
Compare
|
This is still going to be post-devinxi into main? |
|
bunch of conflicts now too |
7945276 to
c9dd38e
Compare
@brenelz It's still up for discussion of this is going straight into devinxi or if it is going into main. Why 😅? |
@brenelz Just rebased it, conflicts are gone 😃. Next on my TODO list: rework the DEV part (try to render |
f1aa3ef to
5518528
Compare
5518528 to
27fef42
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
Design Goals
Issues
?urlimported css should not be server renderedTODO: Needs a better way to detect ?url<link>should be mounted before suspension-end during spa navigation<link>has been loadedmountAssetsin dev (making dev and prod use the same API)Public manifest andasset mount API (Edit: Public manifest API analog to RFC: Client assets metadata API for SSR vitejs/vite#20913 will be implemented in a different branch)Known problems:
<link>is mounted too early on spa navigation - it should wait until resources/createAsync is done