Fix issues with test runs #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aldesantis can we rebase this one please? |
There is an issue with Sprockets 4 not accepting a custom path for the assets manifest, which doesn't play well with in-memory dummy apps such as the one we use in this gem. A fix was provided for sprockets-rails[1] but it was not accepted yet. [1]: rails/sprockets-rails#446
aldesantis
changed the title
|
@kennyadsl done, and also included a fix for AR adapters to allow CircleCI to run with both PostgreSQL and MySQL. I was a bit torn here, because this gem doesn't really need to run with them and could just use in-memory SQLite, but I figured it's better to have the entire ecosystem run tests with the same stack for consistency. At some point in the future we may introduce DB-dependent changes and we don't want to rely on our memory to remember to change the CI configuration then. |
tvdeyen
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two fixes which allow us to run the tests for solidus_support both locally and in CI.
ActiveRecord adapters
Fixes the gem for AR adapters not being loaded.
Sprockets
Fixes an issue where Sprockets complains that there's no manifest file by locking to Sprockets 3.
Unfortunately, Sprockets 4, which introduced manifests, doesn't support specifying a custom path for the assets manifest, which obviously doesn't work with in-memory apps.
@kennyadsl submitted a PR which would allow Sprockets to support custom manifest paths, but it was not merged yet.