Sensormond stop signal logic - incorrect short circuit #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the or short circuits the evaluation if voltage updater returns True... I guess it should've been: ``` if not (self.voltage_updater.update(self.stop_event) and self.current_updater.update(self.stop_event)): ``` We do want them to be chained such that if either returns False it will short circuit and not run the 2nd one (no point in running current updater if voltage receives a stop signal).
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
gordon-nexthop
approved these changes
Aug 21, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prgeor @judyjoseph please help to review this, currently sensormond for current sensors is not working as expected without this |
lotus-nexthop
approved these changes
Oct 1, 2025
louis-nexthop
approved these changes
Oct 1, 2025
|
@gregoryboudreau : please make sure sonic-mgmt test case would have caught this issue. |
abdosi
approved these changes
Oct 1, 2025
|
@judyjoseph please help with sign-off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the or short circuits the evaluation if voltage updater returns True, this was raised as an issue on a comment on original PR, #600: #600 (comment)
We do want them to be chained such that if either returns False it will short circuit and not run the 2nd one (no point in running current updater if voltage receives a stop signal).
Description
Will now short circuit logic if voltage updater returns false (hit a stop signal) and exits functionality as long as either returns false, not if both return false.
Motivation and Context
Testing of #600 involved running manual validations to ensure that sending stop signals during execution was handled in a more timely pace. Was a miss.
How Has This Been Tested?
Reran sensormond daemon, this time through supervisorctl, and can see it coming up w/ voltage and chassis tables correctly.
Above is dump of voltage and current on a system w/ this change present.
Additional Information (Optional)