Fix up xcvrd to use line lanes from gearbox table if present #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
- Implement new method get_gearbox_line_lanes_dict in xcvr_table_helper.py to return a dict of number of gearbox line lanes indexed by logical port. - Building this dict and caching it in CmisTaskManager before a new iteration over port_dict - Implement new method get_host_lane_count to look up the gearbox line lanes in this cached dict for every logical port. If found, use this as the host_lane_count, else use the host_lane_count from port_config - Use this new method when setting host_lane_count for every logical port iteration
aditya-nexthop
force-pushed
the
aditya-gearbox-lanes-xcvrd
branch
from
83e10fe to
7e363fb
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
reviewed
Sep 30, 2025
|
@aditya-nexthop please test the breakout scenario with gearbox to ensure when the user does interface shut or not shut, the Xcvrd only shut/no-shuts the corresponding subport without impacting the other subports. This is to ensure that the lane mask is used properly by Xcvrd |
prgeor
reviewed
Oct 8, 2025
prgeor
previously approved these changes
Oct 8, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
On switches with gearbox PHYs, for a given interface, the number of lanes between the switch ASIC and the gearbox PHY may be different from the number of lanes between the gearbox PHY and the transceiver.
xcvrdcurrently looks only at the switch ASIC lanes (port_config) ashost_lane_countwhich can result inxcvrdeither not finding a matching CMIS application or choosing a wrong application.This change allows
xcvrdto consider the gearbox line lanes ashost_lane_countwhen present. This is accurate to the hardware.How Has This Been Tested?
With this change,
xcvrdis successfully able to select the correct CMIS application on a platform with such a gearbox PHY chip. Additional unit tests have also been added in support of this change.Additional Information (Optional)
fixes #688