Fix duplicate CSEntryChangeResults when ObjectModificationType.Delete #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elete Make sure that ChangedAttributeNames is not processed when ObjectModificationType == Delete
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a bug that caused duplicate key errors during delete operations in the export process. The issue occurred because CSEntryChangeResult was being added twice for delete operations.
- Removed duplicate
CSEntryChangeResult.Add()call for delete operations (line 108)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes error "
PutExportEntriesDetached, An item with the same key has already been added."This problem occurs when the ObjectModificationType = Delete, in that case
results.CSEntryChangeResults.Add()is executed twice.