add MIT-STK #2856
Merged
add MIT-STK #2856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@jopejoe1 - did you copy all the existing markup from MIT in the xml file? It looks like it We don't usually do this. Although, its sort of begs the question of whether we ought to consider it. Generally, we don't add markup, unless variations are actually found, rather than being pre-emptive. Not sure if that may be the case with this variant?? @swinslow - thoughts on this scenario? |
Contributor
Author
|
Indeed, I just copied the MIT license markup and then modified it to match this license. |
Member
|
Thanks @jopejoe1 for the update and sorry I missed it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2827