Skip to content

add py.typed marker for typing #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add py.typed marker for typing #1947

wants to merge 1 commit into from

Conversation

fridex
Copy link

@fridex fridex commented Jul 10, 2024 •
edited
Loading

@fridex
add py.typed marker for typing
5248471 
Signed-off-by: Fridolin Pokorny <[email protected]>
@RobbeSneyders
Copy link
Member

Thanks @fridex!

There were some doubts previously if this is the best way to go if our types are not perfect, see this comment. Do you have a view on that?

@fridex
Copy link
Author

fridex commented Oct 24, 2024

There were some doubts previously if this is the best way to go if our types are not perfect, see this comment. Do you have a view on that?

I've tried mypy on codebase and, sadly, it does not seem to be ready for typing.

@RobbeSneyders
Copy link
Member

Can you expand a bit?

Note that we are running mypy on every commit already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mharding-hpe mharding-hpe mharding-hpe approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fridex @RobbeSneyders @mharding-hpe