Skip to content

Conversation

@kajinamit
Copy link

Changes proposed in this pull request:

  • Replace datetime.datetime.utcnow, which was deprecated in Python 3.12[1]

[1] https://docs.python.org/3.12/library/datetime.html#datetime.datetime.utcnow

Copy link
Contributor

@chrisinmtown chrisinmtown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch v2 has the same test code, would you please submit a similar PR to that?

@kajinamit
Copy link
Author

I opened #2066 for v2 branch. Please let me know if I did it wrong.

@chrisinmtown
Copy link
Contributor

Please approve a run of the GitHub workflow for this PR @Ruwann @RobbeSneyders thanks in advance

@chrisinmtown
Copy link
Contributor

While we all wait for the maintainers to approve a run of the GitHub CI workflow, I cloned https://github.com/kajinamit/connexion.git and ran tox. This branch is a few commits behind main, it still has Python 3.8 and those tests fail for me. Python 3.12 tests and pre-commit checks all pass. Probably should click the button here to rebase this PR onto the latest, please.

@kajinamit
Copy link
Author

I've done rebase locally and updated the source branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants