Skip to content

Replace domain.has_equations() with context['has_maths_elements'] #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace domain.has_equations() with context['has_maths_elements'] #32

wants to merge 1 commit into from

Conversation

@mitya57
Copy link

@mitya57 mitya57 commented May 4, 2025 •
edited
Loading

See sphinx-doc/sphinx@9b7205b.

This is mostly based on that Sphinx commit, with the exception that we default to True, so it unconditionally includes jsmath.js for older Sphinx versions.

This fixes test failure with Sphinx 8.2:

___________________________________________________________________________ test_disabled_when_equations_not_found ___________________________________________________________________________

app = <SphinxTestApp buildername='html'>

    @pytest.mark.sphinx('html', testroot='nomath')
    def test_disabled_when_equations_not_found(app: Sphinx) -> None:
        app.builder.build_all()
    
        content = (app.outdir / 'index.html').read_text(encoding='utf-8')
>       assert 'jsmath.js' not in content
E       assert 'jsmath.js' not in '<!DOCTYPE h...dy>\n</html>'
E         
E         'jsmath.js' is contained here:
E           "/path/to/jsmath.js"></script>
E         ?           +++++++++
E               <link rel="index" title="Index" href="genindex.html" />
E               <link rel="search" title="Search" href="search.html" /> 
E             </head><body>...
E         
E         ...Full output truncated (64 lines hidden), use '-vv' to show

tests/test_jsmath.py:55: AssertionError

@mitya57
Replace domain.has_equations() with context['has_maths_elements']
6adcae1 
See sphinx-doc/sphinx@9b7205b.

This is mostly based on that Sphinx commit, with the exception that we
default to True, so it unconditionally includes jsmath.js for older
Sphinx versions.
@SilverRainZ SilverRainZ mentioned this pull request May 23, 2025
Open
@mitya57
Copy link
Author

mitya57 commented Aug 21, 2025

@AA-Turner Hi, can you take a look at this please?

@AA-Turner
Copy link
Member

AA-Turner commented Aug 21, 2025

We can't publish new PyPI releases: pypi/support#7118

@mitya57
Copy link
Author

mitya57 commented Aug 21, 2025

Oh, interesting. But does the code change look good to you?
I can ship it as a downstream patch in the Debian package for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mitya57 @AA-Turner