Skip to content

fix: add new counter types #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2025
Merged

fix: add new counter types #1274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fdd594
fix: add new counter types
ajasnosz Oct 21, 2025
5bc32f1
docs: update types in docs
ajasnosz Oct 21, 2025
73d65f4
chore: run precommit
ajasnosz Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased

### Changed
- add CounterBasedGauge64 and ZeroBasedCounter64 as metrics types

### Fixes
- fix problem with service rendering when `traps.service.usemetallb` is set to false
Expand Down
11 changes: 6 additions & 5 deletions docs/microk8s/configuration/snmp-data-format.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@ which change dynamically, while textual fields are helpful context to understand

SC4SNMP classifies the data element as a metric when its type is one of the following:

- `Unsigned`
- `Counter`
- `Unsigned32`, `Unsigned64`
- `Counter32`, `Counter64`
- `TimeTicks`
- `Gauge`
- `Integer`

- `Gauge32`, `Gauge64`
- `Integer`, `Integer32`
- `CounterBasedGauge64`
- `ZeroBasedCounter64`
Every other type is interpreted as a field value.

Sometimes, the MIB file indicates a field as an `INTEGER`, but there is also some mapping defined. See the following`IF-MIB.ifOperStatus` example:
Expand Down
4 changes: 3 additions & 1 deletion splunk_connect_for_snmp/snmp/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,9 @@ def get_group_key(mib, oid, index) -> str:
return mib + "::" + ";".join(parts)


MTYPES_CC = tuple(["Counter32", "Counter64", "TimeTicks"])
MTYPES_CC = tuple(
["Counter32", "Counter64", "TimeTicks", "CounterBasedGauge64", "ZeroBasedCounter64"]
)
MTYPES_G = tuple(
["Gauge32", "Gauge64", "Integer", "Integer32", "Unsigned32", "Unsigned64"]
)
Expand Down
Loading