-
Notifications
You must be signed in to change notification settings - Fork 26
improv : optimize ix compute units and cleanup
#25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Nagaprasadvr
commented
Aug 7, 2025
- use derive_pda_address when we are just validating pdas
- remove redundant checks
- remove accounts which arent required and few checks
- Add cu tracker
- show cus and cu diffs using a python script
- remove example
4062beb to
02aaf01
Compare
|
This looks awesome, give me some time to review it |
|
Looking through this, one thing I'd like to keep is the pda calculations in dev/test. I think what I have here is a good compromise. Take a look at this comment for the why. What are your thoughts on this? Regarding the simple hash over the on-curve point method, I do really like that and would prefer to use it over the more expensive is_on_curve checked version that find_program_address ships with. |
|
Cool i will add those tests back ig we can just move thse pda find fncs inside the cfg tests module wyt ? so they are scoped only inside tests |
Yeah actually we don't have to check if it's on curve while validating but only while creating the account so we have the canonical bump |
771d2a3 to
6c724e7
Compare
c3e3333 to
7a34b44
Compare
1fb09b4 to
23007ca
Compare
|
@zfedoran let me know what do u think, more cus to optimize we can do it parallely as we develop. But steel is so cus hungry |
23007ca to
f7aec5e
Compare
f7aec5e to
3c66081
Compare