feat: Add Java OpenFeature provider #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
force-pushed
the
java-provider
branch
2 times, most recently
from
928e266 to
f7f6ffe
Compare
fabriziodemaria
force-pushed
the
java-provider
branch
from
f7f6ffe to
433f520
Compare
fabriziodemaria
commented
Oct 15, 2025
Comment on lines
+189
to
+239
| <plugin> | ||
| <groupId>org.xolstice.maven.plugins</groupId> | ||
| <artifactId>protobuf-maven-plugin</artifactId> | ||
| <version>0.6.1</version> | ||
| <configuration> | ||
| <protocArtifact>com.google.protobuf:protoc:${protobuf.version}:exe:${os.detected.classifier}</protocArtifact> | ||
| <pluginId>grpc-java</pluginId> | ||
| <pluginArtifact>io.grpc:protoc-gen-grpc-java:${grpc.version}:exe:${os.detected.classifier}</pluginArtifact> | ||
| </configuration> | ||
| <executions> | ||
| <!-- Compile the Confidence API protos from this repo to satisfy imports and stubs --> | ||
| <execution> | ||
| <id>compile-confidence-protos</id> | ||
| <phase>generate-sources</phase> | ||
| <goals> | ||
| <goal>compile</goal> | ||
| <goal>compile-custom</goal> | ||
| </goals> | ||
| <configuration> | ||
| <protoSourceRoot>${project.basedir}/../../confidence-resolver/protos</protoSourceRoot> | ||
| <includes> | ||
| <include>confidence/flags/resolver/v1/**/*.proto</include> | ||
| <include>confidence/flags/types/v1/**/*.proto</include> | ||
| <include>confidence/flags/admin/v1/**/*.proto</include> | ||
| <include>confidence/iam/v1/**/*.proto</include> | ||
| <include>confidence/auth/v1/**/*.proto</include> | ||
| <include>google/api/**/*.proto</include> | ||
| <include>google/type/decimal.proto</include> | ||
| <include>confidence/api/annotations.proto</include> | ||
| <include>confidence/events/v1/annotations.proto</include> | ||
| </includes> | ||
| </configuration> | ||
| </execution> | ||
| <!-- Generate WASM interop messages from the shared wasm/proto/messages.proto --> | ||
| <execution> | ||
| <id>compile-wasm-messages</id> | ||
| <phase>generate-sources</phase> | ||
| <goals> | ||
| <goal>compile</goal> | ||
| <goal>compile-custom</goal> | ||
| </goals> | ||
| <configuration> | ||
| <protoSourceRoot>${project.basedir}/../../wasm/proto</protoSourceRoot> | ||
| <includes> | ||
| <include>messages.proto</include> | ||
| </includes> | ||
| <clearOutputDirectory>false</clearOutputDirectory> | ||
| </configuration> | ||
| </execution> | ||
| </executions> | ||
| </plugin> |
There was a problem hiding this comment.
This has been changed and needs thorough review
fabriziodemaria
commented
Oct 15, 2025
Comment on lines
-18
to
+19
| import rust_guest.Messages.SetResolverStateRequest; | ||
| import rust_guest.Messages; | ||
| import com.spotify.confidence.wasm.Messages; | ||
| import com.spotify.confidence.wasm.Messages.SetResolverStateRequest; |
There was a problem hiding this comment.
Note that change of naming in the java packaging
fabriziodemaria
force-pushed
the
java-provider
branch
from
79b0241 to
2ebe795
Compare
andreas-karlsson
approved these changes
Oct 15, 2025
| # Force test stages to run by copying marker files | ||
| COPY --from=confidence-resolver.test /workspace/Cargo.toml /markers/test-resolver | ||
| COPY --from=wasm-msg.test /workspace/Cargo.toml /markers/test-wasm-msg | ||
| COPY --from=openfeature-provider-js.test /app/package.json /markers/test-openfeature |
fabriziodemaria
force-pushed
the
java-provider
branch
from
f92f8b6 to
b571554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported here from the source: https://github.com/spotify/confidence-sdk-java
The plan is to remove this provider from that repo, and unify all WASM-based open feature providers into this repo.
For the reviewer: the Java files in the PR are copied as-is and don't need review. The only change being the import name for
Messages.