fix issue 1970 #1992
Open
fix issue 1970 #1992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wind57 <[email protected]>
wind57
commented
Aug 26, 2025
| @@ -57,32 +57,34 @@ public KubernetesClientServicesListSupplier(Environment environment, | |||
|
|
|||
| @Override | |||
| public Flux<List<ServiceInstance>> get() { | |||
| List<ServiceInstance> result = new ArrayList<>(); | |||
There was a problem hiding this comment.
we had our code as :
public Flux<List<ServiceInstance>> get() {
List<ServiceInstance> result = ....
return Flux.just(result);
}
and it changes to :
public Flux<List<ServiceInstance>> get() {
return Flux.defer(() -> {
List<ServiceInstance> result = ....
return Flux.just(result);
})
}
That is the actual fix.
wind57
commented
Aug 26, 2025
| List<ServiceInstance> result = new ArrayList<>(); | ||
| String serviceName = getServiceId(); | ||
| LOG.debug(() -> "serviceID : " + serviceName); | ||
| return Flux.defer(() -> { |
There was a problem hiding this comment.
same fix as above, nothing changes besides that
wind57
commented
Aug 26, 2025
| @@ -63,24 +56,4 @@ public static Endpoints endpoints(int port, String host, String namespace) { | |||
| .build(); | |||
| } | |||
|
|
|||
| @TestConfiguration | |||
| public static class LoadBalancerConfiguration { | |||
There was a problem hiding this comment.
not removed, but moved to individual classes
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
|
@ryanjbaxter this one is ready too, after the release, got it. thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.