Fix: Include child contexts in auto-configuration conditions report #46951
+28
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, ConditionsReportEndpoint only traversed the parent ApplicationContext hierarchy, which caused conditions from child contexts (e.g. the Actuator's management context) to be missing from the report. This commit updates the context collection logic to: - Traverse both parent and child ApplicationContexts - Use seenIds to avoid duplicate or cyclic references - Ensure child contexts (like Actuator context) are now included in the conditions evaluation report Closes spring-projectsgh-6698 Signed-off-by: Reynolds Liu <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
|
Unfortunately, I don't think we should be finding contexts through bean retrieval. Thanks anyway for the PR. |
wilkinsona
added
status: declined
|
Thanks for the review and clarification, @wilkinsona . Appreciate the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ConditionsReportEndpoint only traversed the parent ApplicationContext hierarchy, which caused conditions from child contexts (e.g. the Actuator's management context) to be missing from the report.
This commit updates the context collection logic to:
Closes gh-6698