Flyway Ignore Migration Patterns setting can't be set to an empty string #46984
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows 'spring.flyway.ignore-migration-patterns' to be set to an empty string to align with Flyway's documented behavior for unsetting default migration patterns. Signed-off-by: Chanwon-Seo <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
mhalbritter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #46969.
Summary
Allows
spring.flyway.ignore-migration-patternsto be set to an empty string to align with Flyway's documented behavior for unsetting default migration patterns.Changes
FlywayAutoConfiguration, removed the condition that prevented an empty list from being passed to Flyway'signoreMigrationPatternsconfiguration.spring.flyway.ignore-migration-patterns=in application properties works as expected.Testing
The existing test
ignoreMigrationPatternsIsEmptyinFlywayAutoConfigurationTestswas used to verify the fix.