Skip to content

Refine DefaultExchangeFunction #35474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −9
Open

Refine DefaultExchangeFunction #35474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions ...lux/src/main/java/org/springframework/web/reactive/function/client/ExchangeFunctions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,22 +74,17 @@ private static class DefaultExchangeFunction implements ExchangeFunction {

private final ExchangeStrategies strategies;

private boolean enableLoggingRequestDetails;
private final boolean enableLoggingRequestDetails;


public DefaultExchangeFunction(ClientHttpConnector connector, ExchangeStrategies strategies) {
Assert.notNull(connector, "ClientHttpConnector must not be null");
Assert.notNull(strategies, "ExchangeStrategies must not be null");
this.connector = connector;
this.strategies = strategies;

strategies.messageWriters().stream()
.filter(LoggingCodecSupport.class::isInstance)
.forEach(reader -> {
if (((LoggingCodecSupport) reader).isEnableLoggingRequestDetails()) {
this.enableLoggingRequestDetails = true;
}
});
this.enableLoggingRequestDetails = strategies.messageWriters().stream()
.anyMatch(writer -> writer instanceof LoggingCodecSupport loggingCodecSupport
&& loggingCodecSupport.isEnableLoggingRequestDetails());
Copy link

@ronodhirSoumik ronodhirSoumik Sep 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional refactoration

this.enableLoggingRequestDetails =
    strategies.messageWriters().stream()
        .anyMatch(writer -> 
            ((writer instanceof LoggingCodecSupport loggingCodecSupport) &&
                 loggingCodecSupport.isEnableLoggingRequestDetails()));

}


Expand Down