Use SmartHttpMessageConverter over GenericHttpMessageConverter where possible
#18075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therepanic
commented
Oct 19, 2025
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.security.oauth2.core; |
There was a problem hiding this comment.
Is the location I chose for the adapter correct?
spring-projects-issues
added
the
status: waiting-for-triage
therepanic
force-pushed
the
gh-18073
branch
2 times, most recently
from
48990fd to
3517081
Compare
…ere possible Closes: spring-projectsgh-18073 Signed-off-by: Andrey Litvitski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use
SmartHttpMessageConverteroverGenericHttpMessageConverter.To get there, we first need to see the classes where
GenericHttpMessageConverteris still used. These areHttpConverterswith the methodsstatic GenericHttpMessageConverter<Object> getJsonMessageConverter(). If we directly replace the return value withSmartHttpMessageConverter, we will see that some classes directly useGenericHttpMessageConverterand its methods.To do this, I decided to create a special adapter
SmartGenericHttpMessageConverterAdapterinto which we can passGenericHttpMessageConverterand use it asSmartHttpMessageConverter. We need this for classes that inherit fromGenericHttpMessageConverter. However, for those who use jackson3, we can directly returnJacksonJsonHttpMessageConverter, which in turn inherits fromSmartHttpMessageConverter.Closes: gh-18073