-
Notifications
You must be signed in to change notification settings - Fork 1
feat(helm)!: Allows for the CSI Provisioner Deployment and CSI Node Driver DaemonSet to be configured independently #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: This tries to align as well as possible to the rather scattered and vague CSI terminology. The charts should be uninstalled and reinstalled to ensure no orphaned and conflicting resources remain. This could impact monitoring setups that depend on the old resource names, labels, and container names.
BREAKING: Helm values that were under `csiNodeDriverRegistrar` are now under `csiNodeDriver`. The reason being is that the "registrar" is only one of the containers in the DaemonSet for the Node Driver.
…tainers are not optional NOTE: These were incorrectly introduced in 463592a while trying to hash out the structure of the values.
17 tasks
This would be rolled out by stackabletech/operator-templating#551
e599bfe
to
ebccce0
Compare
2 tasks
These were introduced in 010207b. Only priorityClassName is valid.
Techassi
previously approved these changes
Sep 16, 2025
Co-authored-by: Techassi <[email protected]>
Techassi
approved these changes
Sep 16, 2025
NickLarsenNZ
added a commit
to stackabletech/secret-operator
that referenced
this pull request
Sep 19, 2025
…tener-operator value changes Part of stackabletech/issues#763 NOTE: These aren't exactly consistent with listener-operator changes from stackabletech/listener-operator#334, but are a step towards consistency, and make it easier should we decide to split secret-operator into a CSI Provisioner Deployment and CSI Node Driver DaemonSet.
NickLarsenNZ
added a commit
to stackabletech/secret-operator
that referenced
this pull request
Sep 19, 2025
…tener-operator value changes Part of stackabletech/issues#763 NOTE: These aren't exactly consistent with listener-operator changes from stackabletech/listener-operator#334, but are a step towards consistency, and make it easier should we decide to split secret-operator into a CSI Provisioner Deployment and CSI Node Driver DaemonSet.
Release NotesRefer to: stackabletech/issues#763 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release-note/action-required
Denotes a PR that introduces potentially breaking changes that require user action.
scheduled-for/25.11.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#763
BREAKING: This change allows for the CSI Provisioner Deployment and CSI Node Driver DaemonSet to be configured independently for many settings. See the explanation below for what changes.
Also add in new configurables for priority and preemption.
Helm Values changes
Caution
The original values are no longer valid.
controller
values have been moved tocsiProvisioner.controllerService
.csiProvisioner
values have been moved tocsiProvisioner.externalProvisioner
csiNodeDriverRegistrar
values have been moved tocsiNodeDriver.nodeDriverRegistrar
.node.driver
values have been moved tocsiNodeDriver.nodeService
.podAnnotations
has been split intocsiProvisioner.podAnnotations
andcsiNodeDriver.podAnnotations
.podSecurityContext
has been split intocsiProvisioner.podSecurityContext
andcsiNodeDriver.podSecurityContext
.nodeSelector
has been split intocsiProvisioner.nodeSelector
andcsiNodeDriver.nodeSelector
.tolerations
has been split intocsiProvisioner.tolerations
andcsiNodeDriver.tolerations
.affinity
has been split intocsiProvisioner.affinity
andcsiNodeDriver.affinity
.Tip
In addition, the following new values are available.
This is part of stackabletech/issues#765.
csiProvisioner.priorityClassName
csiNodeDriver.priorityClassName
Changes to the resource names
testing-listener-operator-deployment
has been renamed totesting-listener-operator-csi-provisioner
app.kubernetes.io/role
label value has changed fromcontroller
toprovisioner
listener-operator
has been renamed tocsi-controller-service
listener-operator-node-daemonset
has been renamed tolistener-operator-csi-node-driver
app.kubernetes.io/role
label value has changed fromnode
tonode-driver
listener-operator
has been renamed tocsi-node-service
Warning
Generally no action is required, but that depends on whether or not your deployment scripts (eg: Kustomize) or monitoring/alerting system depends on any of the names and values.