fix: Don't allow uppercase characters in Kubernetes object names #1095
+101
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeniape
changed the title
siegfriedweber
requested changes
Sep 18, 2025
siegfriedweber
requested changes
Sep 19, 2025
| pub const RFC_1123_LABEL_MAX_LENGTH: usize = 63; | ||
| // This is a modified RFC 1123 format according to the Kubernetes specification, see https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-label-names | ||
| pub const LOWERCASE_RFC_1123_LABEL_FMT: &str = "[a-z0-9]([-a-z0-9]*[a-z0-9])?"; | ||
| const LOWERCASE_RFC_1123_LABEL_ERROR_MSG: &str = "a lowercase RFC 1123 label must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character"; |
There was a problem hiding this comment.
Suggested change
| const LOWERCASE_RFC_1123_LABEL_ERROR_MSG: &str = "a lowercase RFC 1123 label must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character"; | |
| const LOWERCASE_RFC_1123_LABEL_ERROR_MSG: &str = "a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character"; |
|
|
||
| pub const DOMAIN_MAX_LENGTH: usize = RFC_1123_SUBDOMAIN_MAX_LENGTH; | ||
|
|
||
| /// Same as [`RFC_1123_LABEL_FMT`], but allows a trailing dot |
There was a problem hiding this comment.
Suggested change
| /// Same as [`RFC_1123_LABEL_FMT`], but allows a trailing dot | |
| /// Same as [`LOWERCASE_RFC_1123_SUBDOMAIN_FMT`], but allows upper case letters and a trailing dot |
| const RFC_1035_LABEL_FMT: &str = "[a-z]([-a-z0-9]*[a-z0-9])?"; | ||
| const RFC_1035_LABEL_ERROR_MSG: &str = "a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character"; | ||
| // This is a modified RFC 1035 format according to the Kubernetes specification, see https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#rfc-1035-label-names | ||
| const LOWERCASE_RFC_1035_LABEL_FMT: &str = "[a-z]([-a-z0-9]*[a-z0-9])?"; |
There was a problem hiding this comment.
Suggested change
| const LOWERCASE_RFC_1035_LABEL_FMT: &str = "[a-z]([-a-z0-9]*[a-z0-9])?"; | |
| pub const LOWERCASE_RFC_1035_LABEL_FMT: &str = "[a-z]([-a-z0-9]*[a-z0-9])?"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #1064, which introduced uppercase characters in domain names. The updated format was used for domain names as well as container names in Kubernetes for example. But, actually, the Kubernetes RFC 1123 specification is slightly different, only allowing lowercase characters, see https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-label-names. This PR adjusts the separation of usage between the two.
Definition of Done Checklist
Author
Reviewer
Acceptance