fix: output (yaml) userdata in proper base64 encoding for server describe and list commands #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenhoenle
reviewed
Sep 9, 2025
| // Convert each server to map with base64 encoded byte arrays | ||
| convertedServers := make([]map[string]interface{}, len(servers)) | ||
| for i, server := range servers { | ||
| converted, err := sdkutils.ConvertByteArraysToBase64(server) |
There was a problem hiding this comment.
What about JSON output? Isn't the adjustment also needed there?
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira: https://jira.schwarz/secure/RapidBoard.jspa?rapidView=41274&view=detail&selectedIssue=STACKITCLI-219
Convertion Function "ConvertByteArraysToBase64" got added in go-sdk utils that handles proper convertion of byteArrays to base64 strings. It's used for the server list and server describe commands.
Checkout the GO-SDK with branch bf/userdata-base64-fix and replace SDK with local path:
replace github.com/stackitcloud/stackit-sdk-go => /Users/bfuertsch/work/StackIT/stackit-sdk-go
To access the convertion function
Testing Instructions
already well documented in the jira ticket for server describe command (same applies for list command):
https://jira.schwarz/browse/STACKITCLI-219
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)