Skip to content

chore(java): Keep wait packages of services if present #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(java): Keep wait packages of services if present #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions scripts/generate-sdk/languages/java.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,12 @@ generate_java_sdk() {
rm "${SERVICES_FOLDER}/${service}/.openapi-generator-ignore"
rm -r "${SERVICES_FOLDER}/${service}/.openapi-generator/"

# If the service has a wait package, move them inside the service folder
if [ -d ${sdk_services_backup_dir}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if [ -d ${sdk_services_backup_dir}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait ]; then
if [ -d "${sdk_services_backup_dir}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait" ]; then

It's best practice to quote such things in bash 😅

echo "Found ${service} \"wait\" package"
cp -r ${sdk_services_backup_dir}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait ${SERVICES_FOLDER}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cp -r ${sdk_services_backup_dir}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait ${SERVICES_FOLDER}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait
cp -r "${sdk_services_backup_dir}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait" "${SERVICES_FOLDER}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait"

same here

fi

# If the service has a CHANGELOG file, move it inside the service folder
if [ -f ${sdk_services_backup_dir}/${service}/CHANGELOG.md ]; then
echo "Found ${service} \"CHANGELOG\" file"
Expand Down
Loading