Skip to content

feat: Onboard key flow auth #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 8, 2025
Merged

feat: Onboard key flow auth #5

merged 12 commits into from
Aug 8, 2025

Conversation

marceljk
Copy link
Contributor

Description

relates to STACKITSDK-178

Checklist

  • Issue was linked above
  • No generated code was adjusted manually
  • Changelogs
    • Changelog in the root directory was adjusted
    • Changelog(s) of the service(s) were adjusted
  • VERSION file(s) of the service(s) were adjusted
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle
Copy link
Member

Overall I'm missing unit tests here. As this is the core lib I say we need some for sure! 😄

@marceljk marceljk force-pushed the feat/onboard-key-flow-auth branch from bec9223 to b368002 Compare August 1, 2025 15:56
rubenhoenle
rubenhoenle reviewed Aug 4, 2025
View reviewed changes
rubenhoenle
rubenhoenle reviewed Aug 4, 2025
View reviewed changes
rubenhoenle
rubenhoenle reviewed Aug 4, 2025
View reviewed changes
rubenhoenle
rubenhoenle reviewed Aug 4, 2025
View reviewed changes
@marceljk marceljk force-pushed the feat/onboard-key-flow-auth branch from e857948 to 2418447 Compare August 5, 2025 15:05
@marceljk marceljk marked this pull request as ready for review August 6, 2025 09:10
@marceljk marceljk requested a review from a team as a code owner August 6, 2025 09:10
Fyusel
Fyusel reviewed Aug 7, 2025
View reviewed changes
Fyusel
Fyusel reviewed Aug 7, 2025
View reviewed changes
Fyusel
Fyusel reviewed Aug 7, 2025
View reviewed changes
@marceljk marceljk merged commit 2f10254 into main Aug 8, 2025
3 checks passed
@marceljk marceljk deleted the feat/onboard-key-flow-auth branch August 8, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubenhoenle rubenhoenle rubenhoenle left review comments

@Fyusel Fyusel Fyusel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marceljk @rubenhoenle @Fyusel