Skip to content

Conversation

@mitterle-sit
Copy link
Contributor

@mitterle-sit mitterle-sit commented Oct 29, 2025

Description

With some of the newer versions the Observability Instance Ressource generates a lot of diff noise if a alert_config is specified.

 # module.observability.stackit_observability_instance.observability[0] will be updated in-place
  ~ resource "stackit_observability_instance" "observability" ***
      ~ alert_config                           = ***
          ~ global    = ***
              + opsgenie_api_key   = (sensitive value)
              + opsgenie_api_url   = (known after apply)
              ~ resolve_timeout    = "5m" -> (known after apply)
              ~ smtp_auth_identity = "*****" -> (known after apply)
              # Warning: this attribute value will no longer be marked as sensitive
              # after applying this change.
              ~ smtp_auth_password = (sensitive value)
              ~ smtp_auth_username = "*****" -> (known after apply)
              ~ smtp_from          = "[email protected]" -> (known after apply)
              ~ smtp_smart_host    = "*****" -> (known after apply)
          *** -> (known after apply)
            # (2 unchanged attributes hidden)
      ***
        id                                     = "redacted"
        name                                   = "redacted"
      ~ plan_id                                = "redacted" -> (known after apply)
        # (24 unchanged attributes hidden)
  ***

This issue tries to solve this noisiness.
If there are changes needed just let me know.

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@mitterle-sit mitterle-sit requested a review from a team as a code owner October 29, 2025 14:17
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale PR is marked as stale due to inactivity. label Nov 6, 2025
@mitterle-sit
Copy link
Contributor Author

Bump

@marceljk marceljk removed the Stale PR is marked as stale due to inactivity. label Nov 6, 2025
@marceljk
Copy link
Contributor

marceljk commented Nov 6, 2025

Thanks for your contributions! The send_resolve attribute in webhook_configs still creates some diffs, when it's not set in the configuration. This can be fixed when it's explicit set, as mentioned here by you #1003 (comment).

"ms_teams": schema.BoolAttribute{
Description: "Microsoft Teams webhooks require special handling, set this to true if the webhook is for Microsoft Teams.",
Optional: true,
Computed: true,
Default: booldefault.StaticBool(false),
},
"google_chat": schema.BoolAttribute{
Description: "Google Chat webhooks require special handling, set this to true if the webhook is for Google Chat.",
Optional: true,
Computed: true,
Default: booldefault.StaticBool(false),
},
"send_resolved": schema.BoolAttribute{
Description: "Whether to notify about resolved alerts.",
Optional: true,
},

Could you set it to computed and default: true, similar like it's done for google_chat and ms_teams? This would probably fix this issue #1003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants