Skip to content

Conversation

vikin91
Copy link
Contributor

@vikin91 vikin91 commented Sep 12, 2025

Description

The diff should be readable. I mainly wanted to correct the legend that shows now open and closed instead of closedTS=true - this was applied to few places.
Screenshot 2025-09-12 at 10 15 21

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  • Visually in grafana

@vikin91
Copy link
Contributor Author

vikin91 commented Sep 12, 2025

Copy link

openshift-ci bot commented Sep 12, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Sep 12, 2025

Images are ready for the commit at b3f0899.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-760-gb3f089914b.

@vikin91 vikin91 force-pushed the piotr/ROX-30390-update-grafana-dashboards branch from 2592819 to b3f0899 Compare September 12, 2025 08:35
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.80%. Comparing base (510074c) to head (b3f0899).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #16789   +/-   ##
=======================================
  Coverage   48.80%   48.80%           
=======================================
  Files        2681     2681           
  Lines      200443   200443           
=======================================
+ Hits        97824    97825    +1     
+ Misses      95011    95010    -1     
  Partials     7608     7608           
Flag Coverage Δ
go-unit-tests 48.80% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vikin91 vikin91 marked this pull request as ready for review September 12, 2025 09:16
@vikin91 vikin91 requested a review from rhybrillou September 12, 2025 09:16
@vikin91 vikin91 enabled auto-merge (squash) September 12, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants