Skip to content

Conversation

sachaudh
Copy link
Contributor

@sachaudh sachaudh commented Sep 12, 2025

Description

Removed export functionality from the legacy vulnerability management dashboard.

Key Changes:

  • Deleted FixableCveExportButton component entirely
  • Removed export buttons from vulnerability management list and entity page layouts
  • Stripped CSV export functions (exportCvesAsCsv, getCvesInCsvFormat) from VulnerabilitiesService
  • Removed export-related state management and loading indicators from dashboard components
  • Cleaned up unused imports and utility functions (getCveExportName) in vulnerability utils
  • Eliminated export handlers for Image, Node, and Cluster CVE types
  • Removed backdrop loading overlay for export operations

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Before

Screenshot 2025-09-12 at 2 52 05 PM Screenshot 2025-09-12 at 2 52 09 PM Screenshot 2025-09-12 at 2 52 14 PM

After

Screenshot 2025-09-12 at 2 51 20 PM Screenshot 2025-09-12 at 2 51 24 PM Screenshot 2025-09-12 at 2 51 29 PM

Copy link

openshift-ci bot commented Sep 12, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Sep 12, 2025

Images are ready for the commit at d601f96.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-751-gebb31d4984.

Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.85%. Comparing base (1959e3a) to head (d601f96).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16801      +/-   ##
==========================================
- Coverage   48.85%   48.85%   -0.01%     
==========================================
  Files        2686     2686              
  Lines      200796   200796              
==========================================
- Hits        98099    98097       -2     
- Misses      95079    95081       +2     
  Partials     7618     7618              
Flag Coverage Δ
go-unit-tests 48.85% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants