Skip to content

Conversation

@WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

A few more deprecation removals:

  • model.format
  • vb.stan_variable now always returns an np array, and returns the variational sample by default
  • mle.stan_variable now always returns an np array

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian added this to the 2.0 milestone Oct 29, 2025
@WardBrian WardBrian requested a review from amas0 October 29, 2025 16:42
@WardBrian WardBrian mentioned this pull request Oct 29, 2025
2 tasks
Copy link
Collaborator

@amas0 amas0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- one minor change we can make now that the typing of stan_variables has been simplified.

@WardBrian WardBrian merged commit 89dcd4c into develop Oct 30, 2025
19 checks passed
@WardBrian WardBrian deleted the 2.0-more-deprecation-removals branch October 30, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants