-
Notifications
You must be signed in to change notification settings - Fork 65
blockifier_reexecution: use apollo sierra compile to casm #10077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blockifier_reexecution: use apollo sierra compile to casm #10077
Conversation
|
Artifacts upload workflows: |
noaov1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noaov1 reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware)
crates/blockifier_reexecution/src/state_reader/compile.rs line 81 at r1 (raw file):
let serde_value = serde_json::to_value(&sierra).map_err(serde_err_to_state_err)?; let sierra_contract: SierraContractClass = serde_json::from_value(serde_value).map_err(serde_err_to_state_err)?;
Suggestion:
let sierra_contract =
SierraContractClass::try_from(serde_value).map_err(serde_err_to_state_err)?;crates/blockifier_reexecution/src/state_reader/compile.rs line 84 at r1 (raw file):
let sierra_version = SierraVersion::extract_from_program(&sierra_contract.sierra_program) .map_err(StateError::from)?; let raw_class = RawClass::try_from(sierra_contract.clone()).map_err(serde_err_to_state_err)?;
Is the clone needed?
Code quote:
let raw_class = RawClass::try_from(sierra_contract.clone()).map_err(serde_err_to_state_err)?;68832f2 to
3350572
Compare
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @noaov1)
crates/blockifier_reexecution/src/state_reader/compile.rs line 84 at r1 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Is the clone needed?
No
crates/blockifier_reexecution/src/state_reader/compile.rs line 81 at r1 (raw file):
let serde_value = serde_json::to_value(&sierra).map_err(serde_err_to_state_err)?; let sierra_contract: SierraContractClass = serde_json::from_value(serde_value).map_err(serde_err_to_state_err)?;
It doesn't work, we need to impl try_from for Sierra contract class,
for it.
3350572 to
ee7469a
Compare
noaov1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noaov1 reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
ee7469a to
da5700b
Compare
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AvivYossef-starkware reviewed 2 of 2 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @AvivYossef-starkware)
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AvivYossef-starkware reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

No description provided.