Skip to content

Conversation

@AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@AvivYossef-starkware AvivYossef-starkware marked this pull request as ready for review November 11, 2025 09:32
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noaov1 reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware)


crates/blockifier_reexecution/src/state_reader/compile.rs line 81 at r1 (raw file):

    let serde_value = serde_json::to_value(&sierra).map_err(serde_err_to_state_err)?;
    let sierra_contract: SierraContractClass =
        serde_json::from_value(serde_value).map_err(serde_err_to_state_err)?;

Suggestion:

    let sierra_contract =
         SierraContractClass::try_from(serde_value).map_err(serde_err_to_state_err)?;

crates/blockifier_reexecution/src/state_reader/compile.rs line 84 at r1 (raw file):

    let sierra_version = SierraVersion::extract_from_program(&sierra_contract.sierra_program)
        .map_err(StateError::from)?;
    let raw_class = RawClass::try_from(sierra_contract.clone()).map_err(serde_err_to_state_err)?;

Is the clone needed?

Code quote:

    let raw_class = RawClass::try_from(sierra_contract.clone()).map_err(serde_err_to_state_err)?;

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_sierra_compiler_in_blockifier_reexecution branch from 68832f2 to 3350572 Compare November 12, 2025 13:03
Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @noaov1)


crates/blockifier_reexecution/src/state_reader/compile.rs line 84 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Is the clone needed?

No


crates/blockifier_reexecution/src/state_reader/compile.rs line 81 at r1 (raw file):

    let serde_value = serde_json::to_value(&sierra).map_err(serde_err_to_state_err)?;
    let sierra_contract: SierraContractClass =
        serde_json::from_value(serde_value).map_err(serde_err_to_state_err)?;

It doesn't work, we need to impl try_from for Sierra contract class,
for it.

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_sierra_compiler_in_blockifier_reexecution branch from 3350572 to ee7469a Compare November 12, 2025 13:48
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@noaov1 reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/use_sierra_compiler_in_blockifier_reexecution branch from ee7469a to da5700b Compare November 13, 2025 08:22
Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware reviewed 2 of 2 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @AvivYossef-starkware)

Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main-v0.14.1 with commit 8e61078 Nov 13, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants