Skip to content

Conversation

@nadin-Starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nadin-Starkware nadin-Starkware force-pushed the 11-11-apollo_infra_return_reloadhandle_from_configure_tracing branch 3 times, most recently from d81e42c to ad4cc77 Compare November 11, 2025 13:20
@nadin-Starkware nadin-Starkware force-pushed the 11-11-apollo_infra_return_reloadhandle_from_configure_tracing branch from ad4cc77 to b17f6c6 Compare November 12, 2025 08:05
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


crates/apollo_infra/src/trace_util.rs line 24 at r2 (raw file):

    "reqwest",
    "yamux",
];

If we set the default to be Info (which makes a lot of sense) then this becomes redundant. I suggest removing it.

Code quote:

// Crates we always keep at INFO regardless of operator-supplied spec.
const QUIET_LIBS: &[&str] = &[
    "alloy_provider",
    "alloy_transport_http",
    "alloy_rpc_client",
    "futures-util",
    "hickory-proto",
    "hyper",
    "hyper_util",
    "h2",
    "libp2p",
    "libp2p-gossipsub",
    "multistream_select",
    "netlink_proto",
    "reqwest",
    "yamux",
];

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @nadin-Starkware)


crates/apollo_infra/src/trace_util.rs line 70 at r2 (raw file):

        .await;

    reload_handle.clone()

I'd like to make sure a clone can be used to trigger the reloading process.

Code quote:

 reload_handle.clone()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants